[Performance] Memoize isVerbose and isUnitTest in local context#7566
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
gonzaloriestra
force-pushed
the
jules-performance-memoize-env-checks-7311632441309857235
branch
from
62d5fcb to
48483cf
Compare
gonzaloriestra
force-pushed
the
jules-performance-memoize-env-checks-7311632441309857235
branch
2 times, most recently
from
a580b9b to
36245d8
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/context/local.d.ts@@ -11,6 +11,7 @@ export declare function isTerminalInteractive(): boolean;
* @returns The path to the user's home directory.
*/
export declare function homeDirectory(): string;
+export declare function resetEnvironmentMemoization(): void;
/**
* Returns true if the CLI is running in debug mode.
*
|
gonzaloriestra
force-pushed
the
jules-performance-memoize-env-checks-7311632441309857235
branch
from
36245d8 to
6fd3241
Compare
Memoize the result of `isVerbose` and `isUnitTest` when called with `process.env`. These checks are performed frequently in hot paths like logging (`outputDebug`), and memoizing them avoids repeated `process.argv.includes` scans and redundant environment variable lookups. The memoization explicitly bypasses the cache when a custom environment object is provided, ensuring test isolation remains intact. Performance impact: - Reduces overhead in high-frequency logging paths. - Avoids O(N) array scans for the `--verbose` flag on every debug log.
gonzaloriestra
force-pushed
the
jules-performance-memoize-env-checks-7311632441309857235
branch
from
6fd3241 to
0f0944b
Compare
Merge activity
|
gonzaloriestra
deleted the
jules-performance-memoize-env-checks-7311632441309857235
branch
2 participants
WHY are these changes introduced?
Performance-obsessed optimization for hot paths. Environment checks like
isVerboseandisUnitTestare static during the execution of a CLI command but are often checked repeatedly (e.g., in everyoutputDebugcall).WHAT is this pull request doing?
This PR implements lazy-initialized memoization for
isVerboseandisUnitTestinpackages/cli-kit/src/public/node/context/local.ts.memoizedIsVerboseandmemoizedIsUnitTestmodule-level variables.process.env.envobject is passed (crucial for unit tests).How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 7311632441309857235 started by @gonzaloriestra